Ethereum bridge VP and e2e test clean up #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tomas/update-bin-names: cli: update binary names dispatch for namada [ci] docker use rust:1.61.0 update wasm checksums [ci] run specific step in docker container
* tomas/update-changelog-config: update the changelog config to namada repo
* tomas/e2e-fix-cmd-assert: changelog: add #247 test/e2e: update assert_success/failure to first consume output
* tomas/remove-abci: [ci] wasm checksums update ledger: debug log some ABCI++ requests ledger: make prepare_proposal and process_proposal stateless ledger: refactor tx_queue scripts/get_tendermint: update for ABCI++ temp fork release test/e2e/ledger: enable ignored tests for ABCI++ workaround shell: process transaction when `ProcessProposal` hasn't (non-validator) make: remove "*-abci-plus-plus" all: remove "ABCI" conditional compilation deps: remove ABCI dependencies, use ABCI++ as default
* fraccaman+tomas/ci-e2e-validator-logs: [ci] improve e2e log upload to add validator logs
* tomas/expectrl-switch-from-fork: changelog: add #1142 switch from a fork to expectrl v0.5.2
We won't use `queue` anymore, try modifying the DAI supply key instead
"everything" wasn't a good name
tzemanovic
force-pushed
the
james/mainline/ethbridge-cleanup
branch
from
791da5c to
eae2e28
Compare
|
for some reason the eth e2e test failed on the first run (https://github.com/anoma/namada/runs/7792097449?check_suite_focus=true) with: but in the log there's: |
|
pls update wasm |
|
@james-chf is this still relevant? |
|
The test does still need to be cleaned up but it's drifted a bit since this PR I opened anoma/anoma#1252 (on the old anoma repo by accident, will close that and make a new one on namada!) I think this PR could be closed and we can fix it up in |
|
Will fix this up in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved from anoma/anoma#1229
based on #250
This is a PR to the mainline branch to clear up some code relating to the old Ethereum bridge design, which involved maintaining a queue of transfers. Also make the Ethereum bridge end-to-end test slightly clearer.
At the same time, trying to stop this test flaking in CI (#161), though we probably shouldn't close the linked issue even after this PR lands for a while until we have not seen the flake. We need better logging to investigate why it is happening (I have seen it a few times).